Skip to content

fix(ci): restore ESM checks and synchronize docs searches - #10139

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-mts-typecheck
Nov 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-mts-typecheck

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Restore .mts inclusion in the shared scripts project and enforce Node ESM type checking in the root command and existing CI lint job.
  • Synchronize docs search acceptance with its real HTTP response, then retain the existing UI assertions; close the test page on every outcome.

Type of Change

  • Bug fix

Testing

  • Hosted native TypeScript qualification: excluded before/included after, intentional type error rejected with TS2322, restored source passes; all 11 filesystem CLI cases pass.
  • Hosted WebKit deadline regression: genuine HTTP 200 responses completed inside the unchanged five-second client deadline; the old visibility check failed and the synchronized check passed every assertion. Production request and existing UI assertion deadlines remain unchanged.
  • Final hosted qualification: documentation and harness type-checking, existing CLI coverage, committed-artifact generators, and root lint passed. Full PR CI passed at the reviewed commit; Greptile and cubic both reported 5/5 with zero open review threads.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 17, 2026 18:40
@vercel

vercel Bot commented Nov 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Building Building Preview Nov 17, 2026 6:40pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Restores ESM script checks and makes docs search tests wait for the matching HTTP response before checking results.

  • ESM maintenance scripts now run through the root and CI type checks.
  • Docs search tests wait for a successful server response before checking results.

Reviews (1) · Last reviewed commit: "fix(ci): restore ESM checks and synchron..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 7e7a0c8 into staging Nov 17, 2026
92 of 94 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-mts-typecheck branch November 17, 2026 18:45
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Reviewed the neutral secret-scanner result: all reported URL forms are unchanged disposable loopback CI database fixtures already present on the base branch. This follow-up introduces no credential or external database destination.

This branch was successfully deployed

1 active deployment
Preview — c6335812 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant